Properly clear field in clear-pr-merge-commit-message

[vdimir]

Test URLs

Screenshot

[fregante]

What is this about? I need more information. In what scenario does cleanCommitMessage ever return a whitespace-only string?

[vdimir]

It could be connected with any other extension. I tried to disable user-css and user-js, still reproduces. Which additional information may help to investigate?

Firefox Developer Edition 111.0b1 (64-bit) on macOS

Screen.Recording.2023-02-15.at.13.26.52.mov

[fregante]

I see, the change makes sense but the solution can be simplified. The function does not return whitespace-only strings so the issue is exclusively adding the final line break after an empty string.

The solution can be simplified to:

set(field, message ? message + '\n' : '')

Also could you make sure that the linting step passes?

[fregante]

Thank you Vladimir!

[ssbarnea]

I wonder if that bug is related to the one we recently faced, where pressing the merge (squash) button created a very ugly and unexpected commit message: ansible/vscode-ansible#782

It happened several times for at least two different users in the last two weeks and both of us are users of refined-github. Still, we were not able to manually reproduce the issues and the moment we see it is, usually too late to action on it.

[fregante]

Ouch, that's most likely due to Refined GitHub. Can you open an issue with more details about extension version and browser?

It looks like it happened in this sequence:

1. The user opened the merge box
2. clear-pr-merge-commit-message attempted to clear the box, but instead appended the text to the title field (this change is visible and can be prevented)
3. sync-pr-commit-title noticed that the commit title and suggested updating the PR title (this change is also visible and can be prevented)
4. The user clicked Merge ignoring those two visible changes
5. sync-pr-commit-title changed the PR title

[RussKie]

I wonder if that bug is related to the one we recently faced, where pressing the merge (squash) button created a very ugly and unexpected commit message: ansible/vscode-ansible#782

It happened several times for at least two different users in the last two weeks and both of us are users of refined-github. Still, we were not able to manually reproduce the issues and the moment we see it is, usually too late to action on it.

Yes, that's precisely one of the issues I described in #6547.