Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Refined GitHub shortcuts in Shortcut Help dialog #6385

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Conversation

fregante
Copy link
Member

Test URLs

This page, press the ? key

Screenshot

Before After
Screenshot 2 Screenshot 1

@fregante fregante added meta Related to Refined GitHub itself enhancement and removed meta Related to Refined GitHub itself labels Feb 23, 2023
@fregante
Copy link
Member Author

fregante commented Feb 23, 2023

I might reject this because this has the unwanted side effect of losing the g 1 2 3 4 sort 😰

Thoughts? @kidonng

Screenshot

I think as an alternative we should change the shortcuts to say g <tab number> instead:

Screenshot 3

@fregante fregante merged commit e5eae81 into main Feb 24, 2023
@fregante fregante deleted the sort-shrotcuts branch February 24, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Improve shortcuts help
1 participant