-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix one-click-pr-or-gist
private free repos pr creation
#6392
Fix one-click-pr-or-gist
private free repos pr creation
#6392
Conversation
It would be better to check if the "unable to create draft" button exists. Since now if the dom changes at any point we won't see any errors |
I think that we just want to leave the drop-down untouched in that case. Can you craft a selector for that "teams" label and add it as a function in the |
Hi @fregante 👋 |
No, there's no point in keeping the feature enabled for a button that doesn't work. We can't hide it (as in your original screenshot) and we should not hide the inline documentation/explanation. So leaving it alone is the easiest thing to do (also because there will be no one around to fix it when it breaks) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, excellent! 💚
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works, thank you!
Closes #6391
This page affects PR creation in private repos
Screenshot
Without the fix
With the fix