Disable quick-comment-edit on non-editable issues
#6394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Mar 1, 2023
| @@ -59,5 +60,7 @@ void features.add(import.meta.url, { | |||
| include: [ | |||
| pageDetect.hasComments, | |||
| ], | |||
| // The feature is "disabled" via CSS selector when the conversation is locked. | |||
| // We want the edit buttons to appear while the conversation is loading, but we only know it's locked when the page has finished. | |||
There was a problem hiding this comment.
I did not see any changes in the comment’s DOM, they're all marked as "editable".
If anyone sees any differences, please leave a comment or send a PR to move this check from CSS to the addQuickEditButton function (which should be able to tell whether the current comment is editable)
It would be even greater if this could be merged into a single "can comment be edited by current user", replacing the whole selector-based logic we have in canEditEveryComment
There was a problem hiding this comment.
Ugh, ridiculous. There are whole unused forms to update comments (form.js-comment-update) on every comment ever loaded even on locked issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this fix is
hasselector-based: #5797Test URLs
A conversation:
Screenshot