Restore swap-branches-on-compare
#6457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I noticed you sent this before my last comment. How do you feel about this?
Or maybe
|
fregante
changed the title
swap-branches-on-compareswap-branches-on-compare
fregante
reviewed
Apr 6, 2023
|
Yeah a button works too, in that case there's no need to hide it. |
fregante
approved these changes
Apr 8, 2023
|
Because it is... not an icon? Looks too weird and not something clickable to me. |
|
Hey, thanks! A few times, before this feature reappeared, I clicked the three dots beneath the arrow (between the two things to be compared), imagining that a menu would appear with Swap amongst its options. Oops. |
|
The three dots link is a nice touch nonetheless, it just happened to break our feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6361
Test URLs
23.2.1...main
Screenshot