Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pull request review list style #6468

Merged
merged 5 commits into from
Apr 9, 2023
Merged

Fix pull request review list style #6468

merged 5 commits into from
Apr 9, 2023

Conversation

kidonng
Copy link
Member

@kidonng kidonng commented Apr 7, 2023 •
edited

@kidonng kidonng added the bug label Apr 7, 2023
@fregante
Copy link
Member

fregante commented Apr 7, 2023

The Reviews label here is misaligned

PR ### Native
Screenshot 2 Screenshot 3

@fregante fregante self-assigned this Apr 8, 2023
@fregante fregante mentioned this pull request Apr 8, 2023
Merged
fregante
fregante reviewed Apr 8, 2023
View reviewed changes
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the misalignment is due to our own selector on line 24, which would also need :has(.status-meta)

I'd say:

source/features/clean-checks-list.css Show resolved Hide resolved
fregante
fregante approved these changes Apr 9, 2023
View reviewed changes
source/features/clean-checks-list.css Outdated Show resolved Hide resolved
@kidonng @fregante
Apply suggestions from code review
bd1ba5a 
Co-authored-by: Federico Brigante <me@fregante.com>
@fregante
Copy link
Member

fregante commented Apr 9, 2023

Merge at will

@kidonng kidonng merged commit 58f1257 into main Apr 9, 2023
9 checks passed
@kidonng kidonng deleted the fix-review-list-style branch April 9, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

Assignees

@fregante fregante

Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken review list styles in pull requests
2 participants
@kidonng @fregante