Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archive-forks-link feature #6481

Merged
merged 6 commits into from
Apr 9, 2023
Merged

Add archive-forks-link feature #6481

merged 6 commits into from
Apr 9, 2023

Conversation

fregante
Copy link
Member

@fregante fregante commented Apr 9, 2023

@fregante fregante marked this pull request as ready for review April 9, 2023 14:40
@fregante fregante enabled auto-merge (squash) April 9, 2023 14:41
@fregante fregante merged commit c0b22e6 into main Apr 9, 2023
9 checks passed
@fregante fregante deleted the archive-forks-link branch April 9, 2023 14:42
import {buildRepoURL} from '../github-helpers';

function addLinkToBanner(banner: HTMLElement): void {
if (banner.lastChild!.textContent!.includes('repository has been archived')) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kidonng I just realized we have this in the detections, as well as isPublicRepo which I had to drop from useful-forks.

Would you mind linting this in your PR?

Suggested change
if (banner.lastChild!.textContent!.includes('repository has been archived')) {
if (isPublicRepo() && isArchivedRepo()) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 66038a2 (#6488)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants