Restore quick-new-issue on Global navigation update
#6486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
added
meta
fregante
changed the title
quick-new-issue on new stylequick-new-issue on Global navigation update
fregante
commented
Apr 10, 2023
| @@ -177,7 +177,7 @@ export function shouldFeatureRun({ | |||
|
|
|||
| export async function isArchivedRepoAsync(): Promise<boolean> { | |||
| // Load the bare minimum for `isArchivedRepo` to work | |||
| await elementReady('#repository-container-header'); | |||
| await elementReady('main > div'); | |||
There was a problem hiding this comment.
This should work for both. The first div in main appears to always be the flash banner itself or some other empty element if the banner is missing.
I can't use main because that would wait for the whole page before ever resolving, whether the banner exists or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick-new-issuebroken on "Global navigation update" #6455Test URL
here
Demo
Missing
isArchivedRepogithub-url-detection#167