Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "Report repository" link to bottom of sidebar in clean-repo-sidebar #6500

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

kidonng
Copy link
Member

@kidonng kidonng commented Apr 12, 2023

Resolve #6498

I'm tagging as "bug" per original issue but this seems to be "enhancement"?

Test URLs

https://github.com/refined-github/refined-github

Screenshot

Desktop Mobile
image image

@kidonng kidonng added the bug label Apr 12, 2023
async function moveReportLink(): Promise<void> {
await domLoaded;

const reportLink = select('.Layout-sidebar a[href^="/contact/report-content"]')!.parentElement!;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should use :has

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine as is for now, especially because it wouldn't shorten the code much

Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but looks good as is. Bug or enhancement 🤷‍♂️

I'd just look at it on mobile before merging

@kidonng kidonng merged commit 8e06919 into main Apr 12, 2023
11 checks passed
@kidonng kidonng deleted the clean-repo-sidebar branch April 12, 2023 14:57
@fregante fregante changed the title Move "Report repository" link to bottom of sidebar Move "Report repository" link to bottom of sidebar in clean-repo-sidebar Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Reposition new "report repository" in clean-repo-sidebar
2 participants