Fix more-conversation-filters subscription link
#6502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidonng
commented
Apr 12, 2023
fregante
reviewed
Apr 12, 2023
| const subscriptionsLink = commentsLink.cloneNode(true); | ||
| subscriptionsLink.lastChild!.textContent = 'Everything you subscribed to'; | ||
| subscriptionsLink.setAttribute('aria-checked', 'false'); // #4589 | ||
| const subscriptionsLink = select('#filters-select-menu a:last-child')!.cloneNode(true); |
There was a problem hiding this comment.
Why change it? We have the same cloneNode code to create commentsLink. The error suggests that the only issue was the missing input element, which you're also fixing below
There was a problem hiding this comment.
It should be an external link, or it will act like a bogus filter:
Screen.Recording.2023-04-12.at.22.28.32.mov
There was a problem hiding this comment.
Love it. Worth a comment though. I'd perhaps even just extract the source link to its own variable to clarify what it's targeting:
const searchSyntaxLink = select()
const subBlahBlah = searchSyntaxLink.clone(true)
fregante
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6501
Test URLs
https://github.com/refined-github/refined-github/issues
Screenshot
I took the chance to make some slight visual changes:
Because previously when pressing back button you see this: