Fix html-preview-link in new file UI
#6503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidonng
commented
Apr 12, 2023
| className="btn btn-sm BtnGroup-item rgh-html-preview-link" | ||
| className="btn btn-sm BtnGroup-item" |
There was a problem hiding this comment.
Added in 86c0a73#diff-5a0d6407fb78a28cac196b6bf9d7f6e9eccaa02e5098d74df02eb70991c5ee5c for deduplicate, no longer used
kidonng
commented
Apr 12, 2023
| @@ -25,7 +25,7 @@ function add(rawButton: HTMLAnchorElement): void { | |||
| } | |||
|
|
|||
| function init(signal: AbortSignal): void { | |||
| observe('a#raw-url', add, {signal}); | |||
| observe('a:is(#raw-url, [data-testid="raw-button"])', add, {signal}); | |||
There was a problem hiding this comment.
Not sure if this "testid" thing will persist, good enough for now
There was a problem hiding this comment.
Reportedly that attribute is static because it's used in E2E tests. But you never know. Good enough for now
fregante
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6360
Test URLs
https://github.com/CodingTrain/website-archive/blob/4f90eedb9618257d9166241e92e51a7f3f00a08e/code_challenges/PerlinNoiseTerrain_p5.js/index.html
Screenshot