Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Firefox and Safari in options import/export #6518

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

fregante
Copy link
Member

@fregante fregante commented Apr 14, 2023

@fregante fregante marked this pull request as ready for review April 14, 2023 11:51
@fregante
Copy link
Member Author

fregante commented Apr 14, 2023

Of course Safari is in its own league. The file won't be saved but it's just shown and it's up to the user to save it. Even FileSaver.js fails here because it's uses Blob internally.

The closest I got to saving was by using application/octet-stream but it was saved as Unknown.txt, which is worse, because it requires a manual rename.

  • Chrome: Show "Save dialog"
  • Firefox: Automatically save in Downloads folder
  • Safari: Shows JSON

@fregante fregante merged commit b44b2fd into main Apr 14, 2023
9 checks passed
@fregante fregante deleted the firefox-exports branch April 14, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant