Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct view-last-pr-deployment icon #6532

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Conversation

kidonng
Copy link
Member

@kidonng kidonng commented Apr 16, 2023

GitHub represents deployments with rocket icon, I think it is better than a general external link icon.

image

Also changed the copy from "last" to "latest" which is more conventional.

Test URLs

https://github.com//vuejs/core/pull/6160

Screenshot

Screenshot 2023-04-16 at 21 00 48

Copy link
Member

@yakov116 yakov116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fregante fregante changed the title Change view-last-pr-deployment icon Use correct view-last-pr-deployment icon Apr 17, 2023
@fregante fregante merged commit 316aa69 into main Apr 17, 2023
9 checks passed
@fregante fregante deleted the view-last-pr-deployment branch April 17, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants