Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sync-pr-commit-title reliability #6564

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Improve sync-pr-commit-title reliability #6564

merged 3 commits into from
Apr 25, 2023

Conversation

fregante
Copy link
Member

@fregante fregante commented Apr 25, 2023 •
edited

  • Add tests
  • Add comments
  • Improve types
  • Use API instead of submitting local form
  • Ensure the right field is selected if multiple merging options are available
  • Replace onPrMergePanelOpen with observer for Drop most custom event listeners #5992
  • Add observer for PR title

Related:

fregante
fregante commented Apr 25, 2023
View reviewed changes
source/features/sync-pr-commit-title.tsx
await api.v3(`pulls/${getConversationNumber()!}`, {
method: 'PATCH',
body: {title},
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works refined-github/sandbox#62

Screenshot 10

Screenshot 11

@fregante fregante marked this pull request as ready for review April 25, 2023 18:35
@fregante fregante added the bug label Apr 25, 2023
@fregante fregante enabled auto-merge (squash) April 25, 2023 18:35
@fregante fregante merged commit d3c0cc6 into main Apr 25, 2023
9 checks passed
@fregante fregante deleted the sync-pr-commit branch April 25, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fregante