Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari: Restore migrations and the actions button #6586

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Safari: Restore migrations and the actions button #6586

merged 1 commit into from
Apr 27, 2023

Conversation

fregante
Copy link
Member

Includes fregante/webext-polyfill-kinda@8438cd8

Timeline

  1. webext-polyfill-kinda always threw an error when accessing a missing property
  2. webext-options-sync started using webext-polyfill-kinda in v4, including a call to chromeP.management.getSelf()
  3. #6448 started using webext-options-sync v4
  4. 23.4.15 is the first Safari version that includes the above changes
  5. Safari doesn't support chrome.management
  6. Today: the RG icon doesn't nothing in Safari
TypeError: A Proxy's 'target' should be an Object

@fregante fregante added bug safari Related to Safari only labels Apr 27, 2023
@fregante fregante enabled auto-merge (squash) April 27, 2023 10:36
@fregante fregante merged commit 3eb6977 into main Apr 27, 2023
10 checks passed
@fregante fregante deleted the safari-action branch April 27, 2023 10:37
@fregante fregante mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug safari Related to Safari only
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fregante