restore-file UX improvements
#6621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
May 6, 2023
| if (!file) { | ||
| // The file was created by this PR. | ||
| // This code won’t be reached if `highlight-deleted-and-added-files-in-diffs` works. | ||
| throw new Error('Nothing to drop. Delete file instead'); |
There was a problem hiding this comment.
This is now possible. We had only dropped this part because we used to load the native "delete" page and act on that. Now it's much easier via API
| // This code won’t be reached if `highlight-deleted-and-added-files-in-diffs` works. | ||
| throw new Error('Nothing to drop. Delete file instead'); | ||
| if (file?.isTruncated) { | ||
| throw new Error('File too big, you’ll have to use git'); |
There was a problem hiding this comment.
Improved error message, including solution
|
|
||
| const {nameWithOwner, branch: prBranch} = getBranches().head; | ||
| progress(menuItem.closest('[data-file-deleted="true"]') ? 'Undeleting…' : 'Committing…'); | ||
| progress('Committing…'); |
There was a problem hiding this comment.
It's not necessary to differentiate the status here. In every case we're "Committing…"
|
Much better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restore-fileand use new API #6596Changes
Test URLs
https://github.com/refined-github/sandbox/pull/16/files
Screenshot
Prior art
GitHub Desktop
VS Code
cc @134130