Improve reliability of list-prs-for-branch
#6641
Conversation
|
cc @DanielMiao1 |
| @@ -55,7 +56,7 @@ void features.add(import.meta.url, { | |||
| include: [ | |||
| pageDetect.isRepoTree, | |||
| pageDetect.isSingleFile, | |||
| pageDetect.isRepoCommitList, | |||
| isRepoCommitListRoot, | |||
There was a problem hiding this comment.
"List commits for files/folders" don't have a brach selector, so we don't add a default branch button either.
Compare:
|
|
||
| await addAfterBranchSelector(link); | ||
| observe(branchSelectorParent, add, {signal}); |
There was a problem hiding this comment.
Started using the observer, no more awkward code in addAfterBranchSelector
| <a | ||
| className="btn ml-2 px-2 tooltipped tooltipped-ne" | ||
| className="btn px-2 tooltipped tooltipped-ne" |
There was a problem hiding this comment.
Now uses gap for spacing
| @@ -248,3 +248,6 @@ export async function getError(apiResponse: JsonObject): Promise<RefinedGitHubAP | |||
| error.response = apiResponse; | |||
| return error; | |||
| } | |||
|
|
|||
| // Export single API object as default | |||
| export * as default from './api.js'; | |||
There was a problem hiding this comment.
Future lint:
s/import * as api/import api/
| export function extractCurrentBranchFromBranchPicker(branchPicker: HTMLElement): string { | ||
| return branchPicker.title === 'Switch branches or tags' | ||
| ? branchPicker.textContent!.trim() // Branch name is shown in full | ||
| : branchPicker.title; // Branch name was clipped, so they placed it in the title attribute |
There was a problem hiding this comment.
I had dropped this logic in #6629; it's what was breaking list-prs-for-branch on https://github.com/refined-github/sandbox/commits/6538-PR-BRANCH-2 specifically.
| export function addAfterBranchSelector(branchSelectorParent: HTMLDetailsElement, sibling: HTMLElement): void { | ||
| const row = branchSelectorParent.closest('.position-relative')!; | ||
| row.classList.add('d-flex', 'flex-shrink-0', 'gap-2'); | ||
| row.append(sibling); |
There was a problem hiding this comment.
Logic is much simpler nowadays because latest-tag-button is gone. This currently only applies to old non-React views:
- repo home
- repo commit list root
Gone is the long logic from #4236
fregante
changed the title
list-prs-for-branch
list-prs-for-branchbutton is mispositioned/vertically-misaligned/wrapped #6624list-prs-for-branchunreleased-commits