Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust wording of status-subscription’s tooltip #6693

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

waldyrious
Copy link
Contributor

The button group for but the current label ("Subscribe just to the close event") is a little misleading because that subscription level also includes other status change events (e.g. merging a PR or reopening an issue). I slightly reworded the tooltip to be a bit more accurate.

Test URLs

This PR, for instance.

Screenshot

Before:

Screenshot from 2023-05-27 18-01-51

After:

Screenshot from 2023-05-27 18-04-33

@fregante
Copy link
Member

This was intentional, it subscribes to up to three events and I’m not sure I want to make it too verbose. I suppose that it could be both short and correct though:

Subscribe to closing, reopening, merging events

Does this make the tooltip too long? Does it cause issues on mobile? I think we could alternatively wrap it manually via %A0 character (if I remember correctly) to make sure it’s never longer than the column.

@fregante fregante marked this pull request as draft June 1, 2023 04:05
@waldyrious
Copy link
Contributor Author

I think we could alternatively wrap it manually via %A0 character (if I remember correctly) to make sure it’s never longer than the column.

Ah, nice idea. U+00A0 is actually the non-breaking space; newline is U+000A. I believe that in this case, since it's part of an HTML attribute, we need to encode it as an HTML entity (
, or 
 in decimal notation), not as URL-encoded (%0A). I'll make the change.

@waldyrious
Copy link
Contributor Author

@fregante here's what it should look like now:

image

@fregante fregante marked this pull request as ready for review June 6, 2023 13:52
@fregante fregante changed the title Adjust tooltip of status-only subscription button Adjust wording of status-subscription’s tooltip Jun 6, 2023
@fregante fregante added the bug label Jun 6, 2023
@fregante fregante merged commit 36afca9 into refined-github:main Jun 6, 2023
10 checks passed
@fregante
Copy link
Member

fregante commented Jun 6, 2023

Thank you @waldyrious!

@waldyrious waldyrious deleted the patch-1 branch June 6, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants