Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conflict with native mobile toggle in toggle-files-button #6706

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Fix conflict with native mobile toggle in toggle-files-button #6706

merged 3 commits into from
Jun 1, 2023

Conversation

fregante
Copy link
Member

@fregante fregante commented May 31, 2023 •
edited

Test URLs

https://github.com/refined-github/refined-github

Desktop demo

  • new chevron icon 馃啎
  • clicking it shows the native toggle 馃啎
  • reloading the page while collapsed preserves the states
  • reloading the page after expanding it restores the state
Screen.Recording.5.mov

Mobile demo

  • starts collapsed as usual
  • after uncollapsing, the collapse button appears 馃啎
  • reloading the page after expanding does not preserve the state 馃啎 bug fix
Screen.Recording.6.mov

@fregante fregante added the bug label May 31, 2023
@fregante fregante marked this pull request as ready for review May 31, 2023 16:22
@fregante fregante merged commit dc6299c into main Jun 1, 2023
10 checks passed
@fregante fregante deleted the toggle-files-button-merge branch June 1, 2023 04:10
This was referenced Jun 2, 2024
Closed
Merged
fregante added a commit that referenced this pull request Jun 2, 2024
@fregante
Revert #6706
b6d65c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate toggle-files-button with GitHub鈥檚 own file toggle
1 participant
@fregante