Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle renamed files in restore-file #6715

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Handle renamed files in restore-file #6715

merged 2 commits into from
Jun 2, 2023

Conversation

fregante
Copy link
Member

@fregante fregante commented Jun 1, 2023 •
edited

Test URLs

https://github.com/refined-github/sandbox/pull/16/files

Screenshot

Created commit: refined-github/sandbox@12344dc

Demo: (note that here are 2 files initially)

Screen.Recording.mov

@fregante fregante added the bug label Jun 1, 2023
@fregante
Copy link
Member Author

fregante commented Jun 1, 2023

Also tested with

  • discard "new file"
  • discard "deleted file" (in video below)
Screen.Recording.1.mov

@fregante fregante marked this pull request as ready for review June 1, 2023 14:04
@yakov116
Copy link
Member

yakov116 commented Jun 1, 2023

Nice 👌

@fregante
Copy link
Member Author

fregante commented Jun 1, 2023

Noice Thats Nice - yJFeycRK2DB4c

@fregante fregante merged commit 44ccbe3 into main Jun 2, 2023
10 checks passed
@fregante fregante deleted the restore-file-renmae branch June 2, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

restore-file requires two steps on renamed files
2 participants
@fregante @yakov116