Support full project token permission
#6728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMiao1
changed the title
project scope checker in options for tokens with read- and write-access to projectsproject scope checker for tokens with full project control
DanielMiao1
changed the title
project scope checker for tokens with full project controlproject scope checker for tokens with full projects control
fregante
changed the title
project scope checker for tokens with full projects controlproject token permission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6726, the previous fix for issue #6724, works for PATs with only the
read:projectscope selected in GitHub's token creation page, but still shows missing permissions for tokens with full (read- and write-) access to projects, as GitHub's API only reports aproject(instead ofread:project) scope for those tokens:Screenshots
The project scope selector on GitHub's (classic) token creation page:
Before
The permissions page shown for tokens with full control (which includes read-access) of projects
Notice the reported missing permissions for projects
The permissions page shown for tokens with read-only access to projects
The permissions page shown for tokens with permission to everything
Here, the projects scope is reported to be missing, as tokens permission to everything includes write-access to projects, causing the API to return the
project(instead ofread:project) scopeAfter
The permissions page shown for tokens with full control of projects
The permissions page shown for tokens with read-only access to projects
The permissions page shown for tokens with permission to everything
Test locations
Extension options page (varies by browser)
Fully fixes #6724