Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore hide-navigation-hover-highlight on files/notifications #6779

Merged
merged 3 commits into from
Jul 22, 2023

Conversation

fregante
Copy link
Member

@fregante fregante commented Jul 20, 2023

@fregante fregante added the bug label Jul 20, 2023
document.documentElement.addEventListener('navigation:keydown', () => {
document.documentElement.classList.remove(className);
html.classList.add(className);
html.addEventListener('navigation:focus', () => {
Copy link
Member Author

@fregante fregante Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navigation:keydown was the same as keydown, so the style would get lost even if just ctrl was pressed, which was not the intention.

}, {once: true});
}

void features.add(import.meta.url, {
init: onetime(init),
init,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turbo drops all HTML and BODY classes, so they should be re-added every time.

@fregante fregante marked this pull request as ready for review July 21, 2023 14:27
@fregante fregante merged commit b38923f into main Jul 22, 2023
10 checks passed
@fregante fregante deleted the hover-highlight branch July 22, 2023 08:53
fregante added a commit to refined-github/yolo that referenced this pull request Jul 22, 2023
fregante added a commit to refined-github/yolo that referenced this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant