Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forks dropdown bug caused by sticky-sidebar #6781

Merged
merged 2 commits into from
Jul 22, 2023
Merged

Conversation

fregante
Copy link
Member

@fregante fregante commented Jul 21, 2023

Test URLs

Any page

Screenshot

Strangely only the forks dropdown was broken. Now it works. We had the same issue before with the whole action bar

Screen.Recording.mov

@fregante fregante added the bug label Jul 21, 2023
.rgh-sticky-sidebar-enabled #js-repo-pjax-container ul.pagehead-actions,
/* https://github.com/refined-github/refined-github/issues/6761 */
.rgh-sticky-sidebar-enabled [id^='my-forks-menu'] {
z-index: initial !important; /* This affects the social buttons. It seems to have no effect but it constantly causes trouble with other features. */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cause:

Screenshot

@fregante fregante merged commit 377a1c6 into main Jul 22, 2023
10 checks passed
@fregante fregante deleted the sticky-sidebar-z-index branch July 22, 2023 09:12
fregante added a commit to refined-github/yolo that referenced this pull request Jul 22, 2023
fregante added a commit to refined-github/yolo that referenced this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

sticky-sidebar: conflict with the forks menu when :active
1 participant