Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dim unclickable reaction buttons #6795

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Dim unclickable reaction buttons #6795

merged 4 commits into from
Aug 1, 2023

Conversation

fregante
Copy link
Member

@fregante fregante commented Jul 27, 2023

This has annoyed me for quite a while: locked issues still have hoverable buttons. Notice how the button does not turn into a hand, but the background changes:

before

After:

a

Also tested on own reactions:

after

Test URL:

@fregante
Copy link
Member Author

fregante commented Jul 27, 2023

Better yet, I think they should be muted altogether. The bright emojis and avatars still look too clickable:

Screenshot 8

So this is at 50% grayscale:

Screenshot 9

This issue is even more visible on your own reactions:

Screenshot 11

vs the dimmed version in this PR:

Screenshot 10

@fregante fregante marked this pull request as ready for review July 27, 2023 18:12
@fregante fregante changed the title Disable hover state on unclickable reaction buttons Dim unclickable reaction buttons Jul 27, 2023
@fregante fregante merged commit 8e53dc2 into main Aug 1, 2023
11 checks passed
@fregante fregante deleted the locked-reactions branch August 1, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant