Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve page detection #6805

Merged
merged 7 commits into from
Aug 3, 2023

Conversation

kang8
Copy link
Contributor

@kang8 kang8 commented Aug 1, 2023

@fregante
Copy link
Member

fregante commented Aug 1, 2023

Thank you for the PR! There are also other detections that need to be replaced, likely:

@fregante fregante added the bug label Aug 1, 2023
@fregante fregante changed the title Dump github-url-detection to v8 Improve page detection Aug 1, 2023
@kang8
Copy link
Contributor Author

kang8 commented Aug 1, 2023

I found an unexpected behavior for parse- backticks.

Test URL: https://github.com/search?q=repo%3Arefined-github%2Frefined-github+latest+reliable+button+is%3Aissue&type=Issues

Actuall:

image

Expect:
image


It's too late for me now, I'm going to sleep. I'll create an issue for this tomorrow.

@fregante
Copy link
Member

fregante commented Aug 1, 2023

Thank you for the report! I opened an issue:

Co-authored-by: Federico Brigante <me@fregante.com>
@fregante fregante merged commit a234c61 into refined-github:main Aug 3, 2023
9 checks passed
@kang8 kang8 deleted the dump-github-url-detection-to-v8 branch August 3, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants