Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore linkify-user-location in hover cards #6847

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

DanielMiao1
Copy link
Contributor

@DanielMiao1 DanielMiao1 commented Aug 23, 2023

Due to a recent change in title-casing of the aria-label attribute of user location anchors in the GitHub UI, the selector used on line 31 of linkify-user-location.tsx is now invalid.

Test URLs

Before

Screenshot 2023-08-22 at 9 17 14 PM

After

Screenshot 2023-08-22 at 9 18 16 PM

@DanielMiao1 DanielMiao1 marked this pull request as ready for review August 23, 2023 04:24
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

source/features/linkify-user-location.tsx Outdated Show resolved Hide resolved
@fregante fregante changed the title Fix linkify-user-location Restore linkify-user-location in hover cards Aug 24, 2023
@fregante fregante added the bug label Aug 24, 2023
@fregante fregante merged commit ec32c7b into refined-github:main Aug 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants