Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid false positives in dim-bots #6857

Merged
merged 2 commits into from
Aug 27, 2023
Merged

Avoid false positives in dim-bots #6857

merged 2 commits into from
Aug 27, 2023

Conversation

scarf005
Copy link
Contributor

@scarf005 scarf005 commented Aug 26, 2023 •
edited

@scarf005 scarf005 changed the title fix: do not fuzzy match author name fix(dim-bots): do not fuzzy match author name Aug 26, 2023
fregante
fregante requested changes Aug 26, 2023
View reviewed changes
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

The title is not just that, this selector won't match anything, I think.

What about $=

@fregante fregante changed the title fix(dim-bots): do not fuzzy match author name Avoid false positives in dim-bots Aug 26, 2023
@scarf005
Copy link
Contributor Author

image
...oh, missed that.

@fregante fregante added the bug label Aug 27, 2023
@fregante fregante merged commit 2fb9217 into refined-github:main Aug 27, 2023
9 checks passed
@scarf005 scarf005 deleted the patch-1 branch August 27, 2023 20:30
@bramhoven bramhoven mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

@yakov116 yakov116 yakov116 approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dim-bots: false positive when author name starts with bot name
3 participants
@scarf005 @fregante @yakov116