Restore clean-repo-header feature
#6908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d452e4f.
Before
After
|
|
I limited this feature to the new header Affected
Unaffected (except "pins" label)
|
|
This is disruptive when disabling the new Should the CSS in this PR not only be added when |
See the first screenshot, the stars appear 2 times on the page, 400px away |
|
Indeed, I phrased that poorly. I really just meant that this was a downgrade in scannability. Is there any way to only hide the stars when the feature is enabled? |
This was referenced Sep 20, 2023
|
Update to 23.9.21 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6759
The header is still long, ugly and it still causes a wrap and Cumulative Layout Shift.
We can restore it without making it disableable because all of that information is visible in the sidebar, on the same page, as well as in the upcoming:
repo-header-infofeature #6900