Disable dim-bots only when clicking on empty areas
#6910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Sep 13, 2023
| @@ -58,9 +63,6 @@ function init(signal: AbortSignal): void { | |||
|
|
|||
| // Undim on mouse focus | |||
| delegate(dimBots.selector, 'click', undimBots, {signal}); | |||
|
|
|||
| // Undim on keyboard focus | |||
| document.documentElement.addEventListener('navigation:keydown', undimBots, {once: true, signal}); | |||
There was a problem hiding this comment.
Because GitHub crippled this event, I just have to drop it. There's no way to distinguish between an actual navigation and the mere pressing of the ctrl key. So, nothing, I'm not going to rewrite their logic to detect actual j/k navigation.
| @@ -7,7 +7,7 @@ const html = document.documentElement; | |||
|
|
|||
| function init(): void { | |||
| html.setAttribute(attribute, ''); | |||
| html.addEventListener('navigation:focus', () => { | |||
| html.addEventListener('navigation:keydown', () => { | |||
There was a problem hiding this comment.
Bonus bugfix: likewise, just hovering an item focuses the item, so I had to change it to at least keydown (not perfect, but not as noticeable as in dim-bots)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was annoying to do until now: ctrl-click multiple PRs.
This PR makes 2 changes:
Screen.Recording.mov
Test URL
https://github.com/mozilla/web-ext/pulls