Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small-user-avatars - Add avatars to user mentions #6966

Merged
merged 9 commits into from
Oct 4, 2023
Merged

small-user-avatars - Add avatars to user mentions #6966

merged 9 commits into from
Oct 4, 2023

Conversation

Katsute
Copy link
Contributor

@Katsute Katsute commented Sep 28, 2023 •
edited

@Katsute Katsute marked this pull request as ready for review September 28, 2023 02:29
fregante
fregante reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@fregante fregante left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This feature however is a copy-paste of small-user-avatars, so we should probably just alter that feature instead. It would be ok to have two separate observers and addAvatar functions in there

We can use the screenshot suggested below.

readme.md Outdated Show resolved Hide resolved
source/features/mention-avatars.css Outdated Show resolved Hide resolved
@Katsute
Copy link
Contributor Author

Katsute commented Sep 28, 2023

Should I also update the small-user-avatars feature to also include the subscriptions page? Might be a neat thing to have since this feature is being updated

image

@Katsute
Copy link
Contributor Author

Katsute commented Sep 28, 2023

image

@Katsute Katsute changed the title Add mention-avatars feature small-user-avatars - Add avatars to user mentions Oct 1, 2023
@fregante fregante merged commit 1d6552b into refined-github:main Oct 4, 2023
10 checks passed
@Katsute Katsute deleted the mention-avatars branch October 4, 2023 16:33
@grant
Copy link

grant commented Oct 5, 2023 •
edited

This feature works nicely, thanks @Katsute! 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante left review comments

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add avatar to @ user mentions
3 participants
@Katsute @grant @fregante