Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo-header-info - Improve alignment #6987

Merged
merged 7 commits into from
Oct 29, 2023

Conversation

134130
Copy link
Contributor

@134130 134130 commented Oct 17, 2023

Describe

Test URLs

Screenshot

Original 😱

original

vertical-align: text-top βœ…

text-top

vertical-align: bottom πŸ€”

vertical-align-bottom

@134130 134130 changed the title Align repo-header-info with vertical-align: text-top Align repo-header-info Oct 17, 2023
@fregante
Copy link
Member

The alignment in your screenshot appears to be correct, but we should also match the font size exactly

Screenshot 2

@fregante fregante added the bug label Oct 22, 2023
@fregante
Copy link
Member

fregante commented Oct 22, 2023

Also I think this isn't actually affecting Safari for some reason. It looks exactly the same.

The Star alignment is also different from your screenshot. Note that the exact alignment may be different if you zoom the page. This is taken at 100% zoom:

Screenshot 8

Use this to see your alignment

$('.AppHeader-context-item:not([data-hovercard-url])').style.position = 'relative'
$('.AppHeader-context-item:not([data-hovercard-url])').insertAdjacentHTML('beforeend', '<span style="border: solid 1px red; position: absolute; left: 1ch; height: 1.9ex; width: 20ch"></span>')

@134130
Copy link
Contributor Author

134130 commented Oct 29, 2023

image

Please can you check it is aligned on safari?
For align, The font size increased, It looks more highlighted to stargazer count.

Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two classes don't change anything in Safari, do they change the alignment in Chrome?

The font size alone actually fixes the alignment though:

Screenshot 2

@fregante fregante changed the title Align repo-header-info repo-header-info - Improve alignment Oct 29, 2023
@134130
Copy link
Contributor Author

134130 commented Oct 29, 2023

These were remnants of trying with wrapper.

@fregante fregante merged commit 4a9e021 into refined-github:main Oct 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

repo-header-info misaligned
3 participants