Update XO #7374
Merged
Update XO #7374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fregante
commented
May 27, 2024
fregante
commented
- Extracted from Update dependencies #7367
- Follows Update stylelint #7373
yakov116
reviewed
May 28, 2024
sindresorhus
requested changes
May 28, 2024
| @@ -58,7 +58,7 @@ class FeatureFile { | |||
| return existsSync(this.path); | |||
| } | |||
|
|
|||
| // eslint-disable-next-line n/prefer-global/buffer -- Type only | |||
| // eslint-disable-next-line @typescript-eslint/ban-types -- Just passing it | |||
| contents(): Buffer { | |||
There was a problem hiding this comment.
Buffer is a Uint8Array subclass, so you could just use
Suggested change
| contents(): Buffer { | |
| contents(): Uint8Array { |
here.
There was a problem hiding this comment.
Buffer has an includes(string) method but Uint8Array doesn't. Since that's what I'm using it for, I'll keep Buffer for now so I can merge this. Happy to change it if there's a similar method that doesn't require conversions. Maybe later I'll just read it as utf-8 instead
This reverts commit b756861.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.