Shorten Compare URLs #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing CI build with Node 7 seems unrelated to this PR. |
|
Can you replace the 7 with 8? It's annoying that they increased the required version breaking semver, but this change only affects the build anyway. |
|
Increased minimum Nodejs version to 8. All tests pass again. |
|
Thanks! I think the engines field can stay as is, I won't make any changes that break Node 7 compatibility in the published module. v8 is only needed on Travis because of that devDependency requiring it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will detect compare urls.
Input
https://github.com/bfred-it/shorten-repo-url/comparehttps://github.com/bfred-it/shorten-repo-url/compare/d71718db6aa4feb8dc10edbad1134472468e971ahttps://github.com/bfred-it/shorten-repo-url/compare/masterhttps://github.com/bfred-it/shorten-repo-url/compare/master...masterOutput
bfred-it/shorten-repo-url/compare
bfred-it/shorten-repo-url@
d71718d(compare)bfred-it/shorten-repo-url@
master(compare)bfred-it/shorten-repo-url@
master...master(compare)Closes
#16