Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] devtools login not work in Safari #5753

Closed
linkscope opened this issue Mar 14, 2024 · 6 comments · Fixed by #5865 or #5910
Closed

[BUG] devtools login not work in Safari #5753

linkscope opened this issue Mar 14, 2024 · 6 comments · Fixed by #5865 or #5910
Labels
bug Something isn't working
Milestone

Comments

@linkscope
Copy link

linkscope commented Mar 14, 2024

Describe the bug

Hello, when I use devtools in Safari, the error Invalid-session-token will be reported when logging in. This problem will occur regardless of whether I use Github or Google to log in.

Steps To Reproduce

  1. Open the project in Safari
  2. Login when using devtools
  3. The pop-up page reports an error Invalid-session-token

Expected behavior

Log in successfully in Safari

Packages

  • @refinedev/devtools

Additional Context

My MacOS version is Sonoma 14.3.1, Safari version is 17.3.1.

@linkscope linkscope added the bug Something isn't working label Mar 14, 2024
@BatuhanW
Copy link
Member

Hey @linkscope thanks for the report, we'll check it soon.

@BatuhanW BatuhanW changed the title [BUG]devtools login not work in Safari [BUG] devtools login not work in Safari Mar 18, 2024
@aliemir
Copy link
Member

aliemir commented Apr 18, 2024

Hey @linkscope sorry for the issue 🙏 I've just opened up a PR to address this issue. Authentication flow was broken due to cookie issues in Safari. I added a small tweak to the proxy tested it in Chrome and Safari, both are working fine 🚀

@aliemir aliemir added this to the May Release milestone Apr 18, 2024
@linkscope
Copy link
Author

Hey @linkscope sorry for the issue 🙏 I've just opened up a PR to address this issue. Authentication flow was broken due to cookie issues in Safari. I added a small tweak to the proxy tested it in Chrome and Safari, both are working fine 🚀

Thanks a lot for solving this problem and thanks to the team, your efficient work will motivate more people to use Refine.

@lekhok
Copy link

lekhok commented Jun 13, 2024

Facing Same Issue currently, "Invalid Session Token" when signing in with Github

Google Signin doesn't show any error toast notification but redirects to the same login page again.

"@refinedev/cli": "^2.16.21",
"@refinedev/core": "^4.47.1",
"@refinedev/devtools": "^1.1.32",
"@refinedev/kbar": "^1.3.6",

Safari Version 17.5 

As on date : June 13 2024
Screenshot 2024-06-13 at 19 32 58

@Ezers06
Copy link

Ezers06 commented Jun 13, 2024

Also facing same issue but "Invalid Session Token" only show when signing in with Google but my problem is on both Safari and Chrome

Github doesn't show any toast message but keep redirect to login page

"@refinedev/cli": "^2.16.21",
"@refinedev/core": "^4.47.1",
"@refinedev/devtools": "^1.1.32",
"@refinedev/nextjs-router": "^6.0.0",
"@refinedev/kbar": "^1.3.6",

Date : June 13 2024

@lekhok
Copy link

lekhok commented Jun 13, 2024

Also facing same issue but "Invalid Session Token" only show when signing in with Google but my problem is on both Safari and Chrome

Github doesn't show any toast message but keep redirect to login page

"@refinedev/cli": "^2.16.21",
"@refinedev/core": "^4.47.1",
"@refinedev/devtools": "^1.1.32",
"@refinedev/nextjs-router": "^6.0.0",
"@refinedev/kbar": "^1.3.6",

Date : June 13 2024

I opened a new issue #6047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants