-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] types are not exported #6041
Comments
Hey @borisyordanov, sorry for the issue! It seems that we forgot to export this type. If you wish, you can send a PR for this. We would be happy to see your contribution. Check out our Contributing Guide to get started! 🚀 As a workaround, I think you can use import type { HttpError } from "@refinedev/core";
type ValidationErrors = NonNullable<HttpError["errors"]>; |
To make the issue clear for everyone willing to contribute, can you give us a list of types that are missing from the exports? 🙏 |
@aliemir I can make a list, but don't think it'd be practical in the long term to keep the list up-to-date. My advice is to export everything by default. This is what other popular libraries are doing. If this is OK with you I'll submit my PR for review |
@borisyordanov, especially in |
Hi @aliemir, I'd like to fix this and add any other types that are missing from the exports too. |
Hey @FatimaSaleem21 assigning issue to you. |
Describe the bug
It's not possible to
import { ValidationErrors } from '@refinedev/core';
There are many unexported types, i'm using ValidationErrors as an example.
Steps To Reproduce
import { ValidationErrors } from '@refinedev/core'
Expected behavior
All types defined by
@refinedev/core
are exported in the library's index.Packages
@refinedev/core@4.49.1
Additional Context
A temporary workaround
import type { ValidationErrors } from '@refinedev/core/dist/contexts/data/types';
The text was updated successfully, but these errors were encountered: