Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auto-save-indicator): rename key prop to translationKey #6064

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

aliemir
Copy link
Member

@aliemir aliemir commented Jun 20, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

Changes

<AutoSaveIndicator /> components from UI libraries have been using a <Message /> component internally that uses a key prop. Since key is a reserved prop in React, it was causing a warning in the console. This change replaces the key prop with translationKey to avoid the warning.

Resolves #6067

@aliemir aliemir requested a review from a team as a code owner June 20, 2024 14:50
Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: d19253d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@refinedev/chakra-ui Patch
@refinedev/mantine Patch
@refinedev/antd Patch
@refinedev/core Patch
@refinedev/mui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BatuhanW BatuhanW added this to the July Release milestone Jun 20, 2024
Copy link

cypress bot commented Jun 20, 2024

Passing run #11221 ↗︎

0 381 37 0 Flakiness 0

Details:

Merge d19253d into 030111d...
Project: refine Commit: 4dd09123cb ℹ️
Status: Passed Duration: 22:09 💡
Started: Jun 21, 2024 9:52 AM Ended: Jun 21, 2024 10:14 AM

Review all test suite changes for PR #6064 ↗︎

@aliemir aliemir changed the base branch from master to releases/july June 20, 2024 15:39
@aliemir aliemir linked an issue Jun 21, 2024 that may be closed by this pull request
@BatuhanW BatuhanW merged commit b516c18 into releases/july Jun 26, 2024
87 checks passed
@BatuhanW BatuhanW deleted the fix/auto-save-indicator-message-key-prop branch June 26, 2024 08:06
@BatuhanW BatuhanW mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <AutoSaveIndicator /> throws warning for key prop
4 participants