Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite analysis_manager.views.get_full_url() to make it reusable #1063

Closed
hackdna opened this issue Apr 29, 2016 · 3 comments
Closed

Rewrite analysis_manager.views.get_full_url() to make it reusable #1063

hackdna opened this issue Apr 29, 2016 · 3 comments

Comments

@hackdna
Copy link
Member

hackdna commented Apr 29, 2016

This function takes a FileStoreItem instance which leads to code duplication and limited reuse potential. It should take a relative URL instead which would make it usable for creating registration and data set sharing URLs as well.

Options to determine whether http or https URL should be returned:

@scottx611x
Copy link
Member

scottx611x commented May 4, 2016

Evaluating options for http or https usage:

These both require an HttpRequest object, whereas we are currently dealing with relative_urls as strings

These may be good for the future when a Refinery Instance utilizing HTTPS is available to test them out on

This way is simple enough and it make it clear as to/easy to find what protocol we are using since this change exists with all of our other settings

I've currently implemented the last item in the list to take care of construction of our full urls, but the middle 3 links will help out later on.

Once an instance using HTTPS is available to test on, it looks pretty straightforward to implement some of the more robust solutions.

@scottx611x
Copy link
Member

scottx611x commented May 6, 2016

@hackdna Should this be closed for now, and should the suggestions here be implemented in issue: #318 ???

@scottx611x
Copy link
Member

This can be closed upon merging: #1092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants