You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding a file with an unknown file type to the file store should not result in an error. I don't think there is reason why we need to treat this as an error. I think INFO would be appropriate as status in this case. The file store should handle any file type, whether it is known or not.
This is an example sequence in the log (note the ERROR on setting the file_type):
2012-12-11 17:40:23 INFO file_store create: Creating FileStoreItem using source 'http://refinery.med.harvard.edu:8080/datasets/11585f0d18ef92d2?to_ext=txt'
2012-12-11 17:40:23 ERROR file_store set_filetype: 'tgz' is an invalid file type
2012-12-11 17:40:23 INFO file_store create: FileStoreItem created with UUID bff994ec-43e3-11e2-9627-005056a0073d
2012-12-11 17:40:23 DEBUG file_store import_file: Importing FileStoreItem with UUID 'bff994ec-43e3-11e2-9627-005056a0073d'
2012-12-11 17:40:23 WARNING file_store get_absolute_path: Datafile doesn't exist in FileStoreItem bff994ec-43e3-11e2-9627-005056a0073d
2012-12-11 17:40:23 DEBUG file_store import_file: Starting download from 'http://refinery.med.harvard.edu:8080/datasets/11585f0d18ef92d2?to_ext=txt'
2012-12-11 17:40:24 DEBUG analysis_manager.views analysis_status: analysis_manager.views.analysis_status called
2012-12-11 17:40:27 DEBUG analysis_manager.views analysis_status: analysis_manager.views.analysis_status called
2012-12-11 17:40:28 DEBUG file_store import_file: Finished downloading from 'http://refinery.med.harvard.edu:8080/datasets/11585f0d18ef92d2?to_ext=txt'
2012-12-11 17:40:28 DEBUG file_store import_file: u.path = /datasets/11585f0d18ef92d2
src_file_name = 11585f0d18ef92d2
rel_dst_path = c1/b2/11585f0d18ef92d2abs_dst_path = /files/CBMI/ParkLabUnreplicated/refinery-vm/file_store/c1/b2/11585f0d18ef92d2
tmpfile.name = /files/CBMI/ParkLabUnreplicated/refinery-vm/file_store/temp/tmp1T_smw
2012-12-11 17:40:29 DEBUG file_store rename: Renaming FileStoreItem with UUID 'bff994ec-43e3-11e2-9627-005056a0073d'
2012-12-11 17:40:29 DEBUG file_store rename_datafile: Renaming datafile c1/b2/11585f0d18ef92d2 to zipped_output.tgz
2012-12-11 17:40:29 DEBUG file_store _rename_file_on_disk: Renamed /files/CBMI/ParkLabUnreplicated/refinery-vm/file_store/c1/b2/11585f0d18ef92d2 to /files/CBMI/ParkLabUnreplicated/refinery-vm/file_store/f4/a6/zipped_output_11.tgz
2012-12-11 17:40:29 INFO file_store rename_datafile: Datafile renamed
Pivotal Tracker story 41692207 (Nils Gehlenborg - Dec 26, 2012)
The text was updated successfully, but these errors were encountered:
[Fixes #41692207] Added UNKNOWN as a catch-all file type for unknown file types. Modified set_filetype() to accept any file types. (Ilya Sytchev - Dec 27, 2012)
Adding a file with an unknown file type to the file store should not result in an error. I don't think there is reason why we need to treat this as an error. I think INFO would be appropriate as status in this case. The file store should handle any file type, whether it is known or not.
This is an example sequence in the log (note the ERROR on setting the file_type):
2012-12-11 17:40:23 INFO file_store create: Creating FileStoreItem using source 'http://refinery.med.harvard.edu:8080/datasets/11585f0d18ef92d2?to_ext=txt'
2012-12-11 17:40:23 ERROR file_store set_filetype: 'tgz' is an invalid file type
2012-12-11 17:40:23 INFO file_store create: FileStoreItem created with UUID bff994ec-43e3-11e2-9627-005056a0073d
2012-12-11 17:40:23 DEBUG file_store import_file: Importing FileStoreItem with UUID 'bff994ec-43e3-11e2-9627-005056a0073d'
2012-12-11 17:40:23 WARNING file_store get_absolute_path: Datafile doesn't exist in FileStoreItem bff994ec-43e3-11e2-9627-005056a0073d
2012-12-11 17:40:23 DEBUG file_store import_file: Starting download from 'http://refinery.med.harvard.edu:8080/datasets/11585f0d18ef92d2?to_ext=txt'
2012-12-11 17:40:24 DEBUG analysis_manager.views analysis_status: analysis_manager.views.analysis_status called
2012-12-11 17:40:27 DEBUG analysis_manager.views analysis_status: analysis_manager.views.analysis_status called
2012-12-11 17:40:28 DEBUG file_store import_file: Finished downloading from 'http://refinery.med.harvard.edu:8080/datasets/11585f0d18ef92d2?to_ext=txt'
2012-12-11 17:40:28 DEBUG file_store import_file: u.path = /datasets/11585f0d18ef92d2
src_file_name = 11585f0d18ef92d2
rel_dst_path = c1/b2/11585f0d18ef92d2abs_dst_path = /files/CBMI/ParkLabUnreplicated/refinery-vm/file_store/c1/b2/11585f0d18ef92d2
tmpfile.name = /files/CBMI/ParkLabUnreplicated/refinery-vm/file_store/temp/tmp1T_smw
2012-12-11 17:40:29 DEBUG file_store rename: Renaming FileStoreItem with UUID 'bff994ec-43e3-11e2-9627-005056a0073d'
2012-12-11 17:40:29 DEBUG file_store rename_datafile: Renaming datafile c1/b2/11585f0d18ef92d2 to zipped_output.tgz
2012-12-11 17:40:29 DEBUG file_store _rename_file_on_disk: Renamed /files/CBMI/ParkLabUnreplicated/refinery-vm/file_store/c1/b2/11585f0d18ef92d2 to /files/CBMI/ParkLabUnreplicated/refinery-vm/file_store/f4/a6/zipped_output_11.tgz
2012-12-11 17:40:29 INFO file_store rename_datafile: Datafile renamed
Pivotal Tracker story 41692207 (Nils Gehlenborg - Dec 26, 2012)
The text was updated successfully, but these errors were encountered: