Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bulk deletion of Workflows, Analyses, and Datasets properly #1187

Open
scottx611x opened this issue Jun 6, 2016 · 2 comments
Open

Comments

@scottx611x
Copy link
Member

Commit: fbc5a7b

Steps to reproduce

  • Perform a QuerySet delete() upon one of the models mentioned.

Observed behavior

  • If you debug the deletion process you can see that to achieve the proper deletion checking, the QuerySet is iterated over and each object is individual checked if it can be deleted. Then each object that passes these checks is deleted using the Model's delete() method.

Expected behavior

  • The checks that are in place to see if Workflows, Analyses, and Datasets can be deleted should remain, but there should be some logic introduced to perform a bulk deletion on the objects that pass the checks as individual deletions could become costly in the long run.
@hackdna
Copy link
Member

hackdna commented Sep 23, 2016

see also: #1425, #1428 and #480

@jkmarx jkmarx removed this from the Next milestone Oct 20, 2016
@scottx611x scottx611x moved this from Related Open Issues to To Do in Tool APIs May 2, 2017
@scottx611x scottx611x moved this from To Do to Related Open Issues in Tool APIs May 2, 2017
@scottx611x scottx611x moved this from Related Open Issues to To Do in Tool APIs Nov 6, 2017
@scottx611x scottx611x added this to the Next milestone Mar 7, 2018
@scottx611x scottx611x moved this from To Do to Doing in Tool APIs Mar 21, 2018
@hackdna
Copy link
Member

hackdna commented Apr 6, 2018

@hackdna hackdna modified the milestones: Next, Release 1.6.4 Apr 6, 2018
@jkmarx jkmarx modified the milestones: Release 1.6.4, Next May 11, 2018
@jkmarx jkmarx removed this from the Next milestone Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Tool APIs
  
Doing
Development

No branches or pull requests

3 participants