Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow API V2 Exposes All Workflows #1207

Closed
jkmarx opened this issue Jun 14, 2016 · 5 comments
Closed

Workflow API V2 Exposes All Workflows #1207

jkmarx opened this issue Jun 14, 2016 · 5 comments

Comments

@jkmarx
Copy link
Member

jkmarx commented Jun 14, 2016

Commit: f377cda

Steps to reproduce

-- In Django Swagger:

  1. Locally http://192.168.50.50:8000/docs/#!/workflows/Workflow_list
    or
    https://refinery-dev.stemcellcommons.org/docs/#!/workflows/Workflow_list

screen shot 2016-06-14 at 2 04 18 pm

Observed behavior

Workflow API2 allows all CRUD actions, unprotected.

Expected behavior

Which actions do we require?

@jkmarx
Copy link
Member Author

jkmarx commented Jun 14, 2016

@hackdna @ngehlenborg @scottx611x : It doesn't appear the front end is using this API, but I could be mistaken. Please comment on the expected behavior.

@hackdna
Copy link
Member

hackdna commented Jun 14, 2016

The only allowed operation for APIs by default should be a GET.

@scottx611x scottx611x self-assigned this Aug 3, 2016
@scottx611x scottx611x modified the milestones: Barre, Next Aug 3, 2016
@scottx611x
Copy link
Member

I've gotten rid of the Workflow API v2 in one of my recent branches. We should have some discussion if it's worth keeping/upgrading it to DRF.

@ngehlenborg
Copy link
Contributor

Can you please clarify why you would want to get rid of the API?

@scottx611x
Copy link
Member

@nils sure, the api was updated to DRF to support a feature that never came into fruition. I believe #866

I figured if we are not working on this feature I could reimplement the v2 API once #866 comes back into the loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants