Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard - Sharing Modal Bug #1518

Closed
jkmarx opened this issue Nov 14, 2016 · 3 comments
Closed

Dashboard - Sharing Modal Bug #1518

jkmarx opened this issue Nov 14, 2016 · 3 comments

Comments

@jkmarx
Copy link
Member

jkmarx commented Nov 14, 2016

  • Specific code commit: e81a3d9
  • Version of the web browser and OS: Version of the web browser and OS: Chrome Version 54.0.2840.71
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance): Test site, https://test.stemcellcommons.org/#/

Steps to reproduce

Please list all the actions and the input data used:

  1. Open a data set preview
  2. Edit sharing permission
  3. Select cancel
  4. Reopen the sharing

Observed behavior

Sharing permissions did not revert

Expected behavior

Sharing permissions should have reverts to pre-edits.

@jkmarx jkmarx added this to the v1.5.3 milestone Nov 14, 2016
@hackdna hackdna modified the milestones: v1.5.3, v1.5.2 Nov 14, 2016
@jkmarx jkmarx modified the milestones: v1.6.0, v1.5.2, v1.5.3, Next Nov 15, 2016
@ngehlenborg
Copy link
Contributor

I agree, it appears that the "Save" and "Cancel" buttons have no influence on the sharing settings.

@jkmarx jkmarx modified the milestones: v1.6.0, Next Nov 15, 2016
@jkmarx
Copy link
Member Author

jkmarx commented Nov 15, 2016

@ngehlenborg Are we okay with replacing the save and cancel button with a close button?

@jkmarx
Copy link
Member Author

jkmarx commented Nov 15, 2016

Actually the issue isn't with the save and cancel, it's with the data being displayed. For example, modify permissions and don't save. Refresh page, notice the permissions did not save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants