Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Set - Edit Capabilities #1591

Closed
10 tasks done
jkmarx opened this issue Jan 19, 2017 · 3 comments
Closed
10 tasks done

Data Set - Edit Capabilities #1591

jkmarx opened this issue Jan 19, 2017 · 3 comments
Assignees
@jkmarx
Labels
api enhancement ui
Milestone
Release 1.5.4

Comments

@jkmarx
Copy link
Member

jkmarx commented Jan 19, 2017 •
edited

  • Extend the Data Set Api v2 (Django Rest) to include PATCH capabilities. Currently, it only allows deletion.

  • Add serializer for data set api v2 patch
    Fields: name, summary, description, ?slug

  • Add unit tests

  • Add common service for the data set api v2

    • Currently the deletion capabilities in apart of a deletion service
      ? Add deletion to this common service

  • Unit test for common service
    In data set 2 about:

  • Implement form
    Add edit capabilities for those with permission

  • Add edit capabilities for owners

  • Trigger refresh

  • Add unit test for methods

  • Check serialization validations for fields for ex slugs unique
@jkmarx jkmarx added this to the Release 1.5.4 milestone Jan 19, 2017
@jkmarx jkmarx self-assigned this Jan 19, 2017
@jkmarx
Copy link
Member Author

jkmarx commented Jan 20, 2017

http://williamdurand.fr/2014/02/14/please-do-not-patch-like-an-idiot/

@jkmarx
Copy link
Member Author

jkmarx commented Jan 20, 2017

https://tools.ietf.org/html/rfc5789

@jkmarx
Copy link
Member Author

jkmarx commented Jan 20, 2017

http://www.vinaysahni.com/best-practices-for-a-pragmatic-restful-api

@jkmarx jkmarx mentioned this issue Jan 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkmarx jkmarx

Labels
api enhancement ui
Projects
None yet
Milestone
Release 1.5.4
Development

No branches or pull requests
1 participant
@jkmarx