Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"?" help icon should be consistent across pages #1633

Closed
ngehlenborg opened this issue Mar 14, 2017 · 4 comments · Fixed by #1635
Closed

"?" help icon should be consistent across pages #1633

ngehlenborg opened this issue Mar 14, 2017 · 4 comments · Fixed by #1635

Comments

@ngehlenborg
Copy link
Contributor

On the Upload page the icon looks like this (small & light blue) and shows the default (arrow) cursor when hovered:

image

In the File Browser the icon looks like this (bigger and darker blue) and shows the hand cursor when hovered:

image

The color and cursor from the File Browser should be applied to the help icons on the Upload page.

I am not sure about the size, given that there are so many of those icons on the upload page, we might not want to make them any bigger.

@jkmarx
Copy link
Member

jkmarx commented Mar 15, 2017

@ngehlenborg The color for the ? in the file browser is the default link color as oppose to the custom blue used here and the file browser two ?. An option would be to change all the ? to the primary blue button, but since it's an info popover, designating a specific color could be useful. Since it's not a link which redirects, I don't recommend using the default link color.

@ngehlenborg
Copy link
Contributor Author

I agree that the primary button color is not the best choice here. Do we have a secondary button color? If so, we could use that.

Or maybe gray (which is our non-primary button color at the moment) would be sufficient for these buttons? I think people will look for the question mark once they are done reading the text next to it and are looking for an explanation or clarification, so it doesn't have to stand out.

@jkmarx
Copy link
Member

jkmarx commented Mar 15, 2017

@Gray-Light
screen shot 2017-03-15 at 11 03 46 am

Default button color
screen shot 2017-03-15 at 11 02 10 am

@jkmarx
Copy link
Member

jkmarx commented Mar 15, 2017

@ngehlenborg The analysis status unknown uses the same icon and a slate gray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants