Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postcss doesn't do anything #1778

Closed
flekschas opened this issue Jun 7, 2017 · 3 comments
Closed

Postcss doesn't do anything #1778

flekschas opened this issue Jun 7, 2017 · 3 comments
Assignees
@jkmarx
Labels
client core enhancement performance technical debt
Projects
Technical Debt
Milestone
Release 1.6.3

Comments

@flekschas
Copy link
Member

  • Specific code commit: d82da24
  • Version of the web browser and OS: macOs Chrome latest
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance): vm

Steps to reproduce

  1. Check https://github.com/refinery-platform/refinery-platform/blob/develop/refinery/ui/Gruntfile.js#L153-L155

Observed behavior

  • Postcss takes CSS files as input but all our style files are .less
  • Postcss would output files in tmp which is removed after Grunt finishes and the files are not copied over anywhere.

Expected behavior

  • Why is Postcss run?
@jkmarx jkmarx self-assigned this Jun 8, 2017
@jkmarx jkmarx added this to the Release 1.5.7 milestone Jun 8, 2017
@jkmarx
Copy link
Member

jkmarx commented Jun 8, 2017

https://github.com/refinery-platform/refinery-platform/issues/1778

@jkmarx
Copy link
Member

jkmarx commented Jun 9, 2017

Ref: #1528
https://github.com/refinery-platform/refinery-platform/pull/1571/files

@jkmarx
Copy link
Member

jkmarx commented Jun 9, 2017 •
edited

https://david-dm.org/less/less-plugin-autoprefix#info=devDependencies

@jkmarx jkmarx removed this from the Release 1.5.7 milestone Jun 15, 2017
@scottx611x scottx611x added this to Dependencies in Technical Debt Oct 20, 2017
@jkmarx jkmarx modified the milestones: Release 1.6.2, Next Jan 3, 2018
@jkmarx jkmarx modified the milestones: Next, Release 1.6.3 Jan 17, 2018
@jkmarx jkmarx mentioned this issue Feb 8, 2018
Merged
@jkmarx jkmarx closed this as completed Feb 9, 2018
Technical Debt automation moved this from Dependencies to Done Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkmarx jkmarx

Labels
client core enhancement performance technical debt
Projects
Technical Debt
  
Done
Milestone
Release 1.6.3
Development

No branches or pull requests
2 participants
@flekschas @jkmarx