Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix names of REST API view classes #3345

Closed
7 tasks done
hackdna opened this issue Apr 24, 2019 · 1 comment
Closed
7 tasks done

Fix names of REST API view classes #3345

hackdna opened this issue Apr 24, 2019 · 1 comment
Assignees
@jkmarx
Labels
api important server technical debt
Projects
Technical Debt
Milestone
Release 1.7.0

Comments

@hackdna
Copy link
Member

hackdna commented Apr 24, 2019 •
edited by jkmarx

Several REST API view class names don't correspond to their respective base classes.

The following "viewsets" are derived from APIView:

  • EventViewSet
  • AnalysisViewSet
  • SiteProfileViewSet
  • UserProfileViewSet
  • StudyViewSet
  • FileStoreItems
  • UserFiles

They should be renamed.
@hackdna hackdna added this to the Next milestone Apr 24, 2019
@hackdna hackdna added this to Backlog in Technical Debt via automation Apr 24, 2019
@jkmarx jkmarx modified the milestones: Next, Release 1.7.0 May 6, 2019
@jkmarx jkmarx self-assigned this May 6, 2019
This was referenced May 13, 2019
Merged
Merged
@jkmarx
Copy link
Member

jkmarx commented Jun 3, 2019

Closed with #3381

@jkmarx jkmarx closed this as completed Jun 3, 2019
Technical Debt automation moved this from Backlog to Done Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkmarx jkmarx

Labels
api important server technical debt
Projects
Technical Debt
  
Done
Milestone
Release 1.7.0
Development

No branches or pull requests
2 participants
@hackdna @jkmarx