Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary warning when importing data sets without data files #3360

Closed
hackdna opened this issue Apr 30, 2019 · 0 comments
Closed

Unnecessary warning when importing data sets without data files #3360

hackdna opened this issue Apr 30, 2019 · 0 comments
Assignees
@jkmarx
Labels
bug client dataset import ui
Milestone
Release 1.6.9

Comments

@hackdna
Copy link
Member

hackdna commented Apr 30, 2019

  • Specific code commit: fdf35ba
  • Version of the web browser and OS: any
  • Environment where the error occurred: Vagrant and AWS

Steps to reproduce

  1. Open ISA-Tab import page
  2. Select an ISA archive
  3. Click Submit button

Observed behavior

A warning about uploading remote data files is shown even though the answer to the question "Would you like to upload files?" is "No".

Screen Shot 2019-04-30 at 14 46 09

This is confusing because there was no intention to upload any data files.

Expected behavior

No warning before submitting a data set for import if no data files are to be uploaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkmarx jkmarx

Labels
bug client dataset import ui
Projects
None yet
Milestone
Release 1.6.9
Development

No branches or pull requests
2 participants
@hackdna @jkmarx