Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_set_manager has test with non-determinstic behavior #3444

Closed
ilan-gold opened this issue Sep 9, 2019 · 0 comments · Fixed by #3447
Closed

data_set_manager has test with non-determinstic behavior #3444

ilan-gold opened this issue Sep 9, 2019 · 0 comments · Fixed by #3447

Comments

@ilan-gold
Copy link
Member

ilan-gold commented Sep 9, 2019

  • Specific code commit:
  • Version of the web browser and OS:
  • Environment where the error occurred (Vagrant VM and site conf mode or AWS instance):

Steps to reproduce

Please list all the actions and the input data used:

  1. Move the actual test functionality into its own function
  2. Run that function inside a while-true loop inside the actual test until it fails

Observed behavior

  • The test test_get_with_study_uuid_returns_file_uuid_field fails randomly because the order of nodes serialized/returned is non-deterministic
  • This causes the first_node to sometimes be a node lacking a file_uuid field.

Error Traceback (most recent call last): File "/vagrant/refinery/data_set_manager/test_views.py", line 815, in test_get_with_study_uuid_returns_file_uuid_field self.get_with_study_uuid_returns_file_uuid_field() File "/vagrant/refinery/data_set_manager/test_views.py", line 830, in get_with_study_uuid_returns_file_uuid_field raise e AttributeError: 'NoneType' object has no attribute 'uuid'

Expected behavior

  • The test should always pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants