New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISA archive is imported even if it has been imported previously #562
Comments
The problem is caused by a trailing white space in the study title. (Thanks lord for trailing white spaces!) The Isatab-parsers's MD5 checker removed trailing white spaces but the normal |
Any thoughts on what (remove whitespace or not) would be the better approach here? |
Removing. Unless we want to have data sets named like |
Thanks for fixing the problem so quickly. Since this piece of code is used in two different places, it should be abstracted out into a separate method. |
Please open a new issue for refactoring since this bug had been solved. |
Still occurs on f6186fe with the following ISA archives:
|
Works fine for me. For example for isa_15576_819296.zip
|
just reproduced this by re-running twice with a batch of 50 files:
|
I am also unable to reproduce this. |
Have you tried with a batch of 50 files? |
Yes works as expected. |
@hackdna: Still no luck? |
Were there any fixes pushed? |
You are the only one reporting that error. Since I can't reproduce it I am unable to to debug. |
Can you check the version number in the "Details" tab of the data set browser? |
It shows one version. |
Version 1? |
Actually, no: I see version 10 and 11 for example. |
Ok, so it is importing those data sets multiple times. |
I'm moving this to 0.0.5 |
I've uploaded |
Steps to reproduce
Run process_isatab management command several times. For example:
manage.py process_isatab admin ~/sccdata/51-100
Observed results
Command output on the first run:
49 / 50: Successfully parsed isa_9505_764988.zip into DataSet with UUID 214ca952-4484-4b09-83e6-d98e0e8c5445
Command output on subsequent runs:
49 / 50: Successfully parsed isa_9505_764988.zip into DataSet with UUID 214ca952-4484-4b09-83e6-d98e0e8c5445
Expected results
Command output on the first run:
49 / 50: Successfully parsed isa_9505_764988.zip into DataSet with UUID 214ca952-4484-4b09-83e6-d98e0e8c5445
Command output on subsequent runs should indicate that the file is being skipped as it has been successfully parsed already.
The text was updated successfully, but these errors were encountered: