Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace simplejson Python module #589

Closed
hackdna opened this issue Aug 11, 2015 · 12 comments
Closed

Replace simplejson Python module #589

hackdna opened this issue Aug 11, 2015 · 12 comments

Comments

@hackdna
Copy link
Member

hackdna commented Aug 11, 2015

Simplejson was deprecated from Django. This will reduce number of dependencies and potentially increase processing speed.

We should probably just use json module from the Python standard library.

@hackdna hackdna added this to the Release 0.0.5 milestone Aug 11, 2015
@ngehlenborg ngehlenborg modified the milestones: Release 0.0.5, Release 0.0.6, TDB 1 Aug 14, 2015
@ngehlenborg
Copy link
Contributor

There is also https://pypi.python.org/pypi/ujson.

@hackdna hackdna changed the title Replace simplejson Python module with json Replace simplejson Python module Oct 7, 2015
@flekschas
Copy link
Member

Here's a comparison of ujson against other libs: https://github.com/esnme/ultrajson#benchmarks
And another benchmark: http://blog.dataweave.in/post/87589606893/json-vs-simplejson-vs-ultrajson

UltraJSON seems superior.

@hackdna
Copy link
Member Author

hackdna commented Oct 9, 2015

We should also consider compatibility with Django, maturity and popularity of the project (as a proxy for future support) in addition to performance.

@scottx611x scottx611x self-assigned this Feb 11, 2016
@scottx611x scottx611x added this to the Oak Bluffs milestone Feb 11, 2016
@scottx611x
Copy link
Member

Closing according to: https://docs.djangoproject.com/fr/1.5/releases/1.5/#system-version-of-simplejson-no-longer-used

simplejson is deprecated as of Django 1.5 and use of Python's stdlib json module is reccomended

See commit: 1548f6c

@hackdna
Copy link
Member Author

hackdna commented Feb 11, 2016

I still find a lot of references to simplejson in the codebase (17f94e5).

@hackdna hackdna reopened this Feb 11, 2016
@hackdna hackdna modified the milestones: Next, Oak Bluffs Feb 11, 2016
@hackdna hackdna added the server label Feb 11, 2016
@scottx611x
Copy link
Member

@hackdna Just double checked, there are six occurrences within comments. Everything else is in celery logs.

@scottx611x
Copy link
Member

Closing with 0c6ef29

@flekschas
Copy link
Member

A quick question: having had a look at ujson again. Would it make sense to keep that in the backlog for the future? It outperforms the standard library under all condition and often significantly.

@hackdna
Copy link
Member Author

hackdna commented Feb 11, 2016

We'll keep it mind if we see any performance problems related to JSON manipulation.

@hackdna
Copy link
Member Author

hackdna commented Feb 11, 2016

@scottx611x: PyCharm found 50 occurrences of simplejson.
screenshot 2016-02-11 13 44 50

@hackdna hackdna reopened this Feb 11, 2016
@scottx611x
Copy link
Member

Using cc2648e

screen shot 2016-02-11 at 1 50 44 pm

@scottx611x scottx611x reopened this Feb 11, 2016
This was referenced Feb 11, 2016
@scottx611x
Copy link
Member

Closed with a4eb092

@flekschas flekschas modified the milestones: Next, Oak Bluffs Feb 23, 2016
@hackdna hackdna mentioned this issue Feb 7, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants