Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dataset nav feature needs refactoring #639

Closed
flekschas opened this issue Aug 26, 2015 · 7 comments
Closed

The dataset nav feature needs refactoring #639

flekschas opened this issue Aug 26, 2015 · 7 comments

Comments

@flekschas
Copy link
Member

Currently data-set-nav/ is a set of different features put all together. It'd be better to separate concerns.

There are two options in my mind:

  1. Create a feature directory for datasets and create separate files for each tab's controller
  2. Create feature directories for each tab

Our approach should depend on the complexity of the tabs.

@ngehlenborg
Copy link
Contributor

@jkmarx: Has this been taken care off in your recent restructuring?

@jkmarx
Copy link
Member

jkmarx commented Oct 12, 2015

No, we need to discuss Fritz's suggestions up above.

@flekschas
Copy link
Member Author

I added the ticket just as a reminder to refactor the dataset nav state file for example. Currently it contains like 5 or more controllers. So its rather bundled by function then by feature. Anyway, this will probably be taken care of when fully angularizing the dataset page.

@jkmarx
Copy link
Member

jkmarx commented Dec 15, 2015

1 similar comment
@jkmarx
Copy link
Member

jkmarx commented Feb 22, 2016

@scottx611x
Copy link
Member

#639

@jkmarx
Copy link
Member

jkmarx commented Oct 5, 2016

Closing this issue because it isn't necessary. The refactoring of the data set nav is on-going with the data set 2 upgrade. Pull request #1413 began the process. After the data set 2 upgrade is complete, this issue will be resolved by default.

@jkmarx jkmarx closed this as completed Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants