-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The dataset nav feature needs refactoring #639
Comments
@jkmarx: Has this been taken care off in your recent restructuring? |
No, we need to discuss Fritz's suggestions up above. |
I added the ticket just as a reminder to refactor the dataset nav state file for example. Currently it contains like 5 or more controllers. So its rather bundled by function then by feature. Anyway, this will probably be taken care of when fully angularizing the dataset page. |
1 similar comment
Closing this issue because it isn't necessary. The refactoring of the data set nav is on-going with the data set 2 upgrade. Pull request #1413 began the process. After the data set 2 upgrade is complete, this issue will be resolved by default. |
Currently
data-set-nav/
is a set of different features put all together. It'd be better to separate concerns.There are two options in my mind:
Our approach should depend on the complexity of the tabs.
The text was updated successfully, but these errors were encountered: